Removed unused vuetify components

[drona-gyawali]

Remove all unused Vuetify components declared in shared/app.js

Summary

• There is a components file inside app.js where components are declared, and I got a task to remove the unused components from the file.

…

References

closes #4893
…

Reviewer

@akolson @MisRob
…

[MisRob]

Hi @drona-gyawali, thank you.

From brief skim, I think that the removal of VIcon and VMenu from the globally defined list makes sense. Even though we use these two, they are imported directly at the relevant places with import { VMenu } from 'vuetify/lib/components/...; so if everything still works, it should be okay.

Before I assign reviewers - would you please mention if you confirmed that all other global components are indeed being used, and mentioned a bit a method you used to check on them? It will help us to determine how to approach the review. Thank you.

[drona-gyawali]

Hi @MisRob, I wrote a script and used IDE search functionality to scan the entire codebase for component usage. I converted component names from PascalCase to kebab-case to cover all potential naming variations, and even checked dynamic usages. This process helped me confidently identify which components are actively used and which ones can be safely removed.

[akolson]

Hi @drona-gyawali! Great work on the script. However a manual check on the two removed components shows that they are still actively used -- in custom components ie VIconWrapper and Menu respectively.

So we definitely have our answer now :) ; all declared Vuetify components are being used so we can safely close this issue and without making any changes. I am adding a little blocker to prevent any accidental merges.

Thanks again for picking and investigating this. Please feel free to request any other issues. We look forward to hearing from you soon.

[akolson]

Circling back to @MisRob's comment(Which I hadn't seen), I think we can remove them.

[MisRob]

Hi @drona-gyawali, was there any reason for closing this? Looking at @akolson's review, I believe we were going to merge.

[drona-gyawali]

Sorry @MisRob, that was my mistake. I've reopened it now.

[MisRob]

No worries @drona-gyawali, thank you. @akolson I think we could merge?

[MisRob]

Thanks @drona-gyawali!