Migrate accounts section from less to scss#4891
Closed
adibmbrk wants to merge 2 commits intolearningequality:unstablefrom
Closed
Migrate accounts section from less to scss#4891adibmbrk wants to merge 2 commits intolearningequality:unstablefrom
adibmbrk wants to merge 2 commits intolearningequality:unstablefrom
Conversation
Member
|
Hi @adibmbrk! Great work on the migration. It appears to me that this is only a fraction to what I think the issue requires. Could you please clarify on what your plan of development is? Thanks |
Contributor
Author
Hey @akolson, I have updated the issue with my plan, please let me know if you have any suggestions. |
Member
|
Hey @adibmbrk! Please see #4827 (comment) |
Contributor
Author
|
Closing this PR to maintain a single PR for the entire migration effort as suggested by @akolson since it's easier to review and test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the LESS used in the entire accounts section to SCSS.
In Create.vue I removed unused styling that has been included previously. We can confirm that it's unused by looking at the browsers developer tools. There is no
.v-input__slotdeeply nested withinpolicy-checkboxthereby ensuring us that it's unused and safe to remove.…
References
…