Core functionality of connect and make_request methods on Backend class#4494
Merged
bjester merged 9 commits intolearningequality:search-recommendationsfrom May 16, 2024
Merged
Conversation
6ca86a0 to
283abc6
Compare
24 tasks
bjester
requested changes
Apr 3, 2024
Member
bjester
left a comment
There was a problem hiding this comment.
For the most part, it looks great! Mostly some small things. The most important things that could use attention are:
- the issue with
url_prefix="", *args, **kwargs - exception logging
- retry behavior
- repeat calls to
__init__
Member
|
I have merged #4499 so rebasing this PR on the current search-recommendations branch should fix the build issue that was observed here! |
b7c7a3f to
267935c
Compare
bjester
reviewed
May 2, 2024
Member
bjester
left a comment
There was a problem hiding this comment.
Looking great! Sorry for the late followup. I responded to your question about the timeouts.
Member
Author
|
Thank you @bjester!! Just added the timeout to the backend request 👐. |
bjester
reviewed
May 6, 2024
bjester
requested changes
May 14, 2024
Member
bjester
left a comment
There was a problem hiding this comment.
Revisiting this I caught more things. Sorry for the back and forth. I think this will be the last before approval.
Member
Author
|
Thank you @bjester! I have addressed the comments 👐. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Implements the core funcitonlity and error handling of the
connectandmake_requestmethods on theBackendclass.Manual verification steps performed
Created various sub-classes of the
Backendclass testing itsconnectandmake_requestsmethods.Reviewer guidance
How can a reviewer test these changes?
Play with the
Backendclass, making sub-classes in thetest_base.pyfileReferences
Closes #4447
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)