Node.js 18, pnpm 8, jest 29, linting/formatting updates, and webpack fixes#4462
Merged
bjester merged 11 commits intolearningequality:unstablefrom Apr 29, 2025
Merged
Node.js 18, pnpm 8, jest 29, linting/formatting updates, and webpack fixes#4462bjester merged 11 commits intolearningequality:unstablefrom
bjester merged 11 commits intolearningequality:unstablefrom
Conversation
9 tasks
Merged
9 tasks
Member
Author
|
Need to check whether we can upgrade |
cf8f431 to
d4b7f6c
Compare
7edf4e8 to
c52f2a9
Compare
509d739 to
58a0221
Compare
rtibbles
previously approved these changes
Apr 9, 2025
Member
rtibbles
left a comment
There was a problem hiding this comment.
I have reviewed all the commits that it would be safe to do so/that I haven't already reviewed. One possible issue in the flake.nix file, but it already seems to be non-functional, so I am not sure we actually need to block this PR for it.
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Use pnpm |
Member
There was a problem hiding this comment.
I was a little surprised that this comes before the Node setup, but not so surprised that I care to understand why it is suggested to be this way in the documentation!
I got a bit over eager - going to manually test the pnpm workflow first!
rtibbles
approved these changes
Apr 9, 2025
Member
rtibbles
left a comment
There was a problem hiding this comment.
Manual testing of the switchover to pnpm (using volta) shows no issues, absolutely seamless.
This was referenced Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
pnpm run lint-frontend:formatManual verification steps performed
pnpm run test-jestpnpm run devserver:hotReferences
Requires: learningequality/kolibri#12052
Comments