[12.x] AbstractPaginator should implement CanBeEscapedWhenCastToString
#55256
+30
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you pass a paginator to an anonymous blade component, the paginator will be converted to a string in the process, which causes the paginator's
render()method to be called. The blade component receives the paginator object in the end, but it does not make sense that the paginator is rendered to a string while passing the object from one blade file to another.This PR fixes that by implementing
CanBeEscapedWhenCastToStringinterface on theAbstractPaginatorclass. This is the same as the implementation of that interface onModel,Collection, ... classes (see #39319)