[12.x] Fix DateFactory docblock type hints #55244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #55235 and #55243. These previous PRs addressed the issue of
DateTimeInterfaceandDateTimeZone, but after merging, I realized there were a few more mistakes.#55151, which added Carbon v3 compatibility, first introduced these issues since the docblocks in
Carbon/Factory.phpdid not include the namespace for the classes, since they were imported into the file directly, unlike in Laravel'sDateFactory.php.Fixes:
TranslatorInterface->\Symfony\Contracts\Translation\TranslatorInterfaceClosure->\ClosureWeekDay->\Carbon\WeekDayMonth->\Carbon\MonthCarbonInterface->\Carbon\CarbonInterfaceApologies for not catching this in my previous PR, I'm sure docblock-only PRs are annoying 🙄.