[12.x] Allow configuration of retry period for RoundRobin and Failover mail transports #55222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Symfony RoundRobinTransport has a
retryPeriodargument in its constructor (see https://github.com/symfony/mailer/blob/f3871b182c44997cf039f3b462af4a48fb85f9d3/Transport/RoundRobinTransport.php#L38), that allows one to configure how long a failing transport instance should be considered as 'dead' before retrying. This MR aims to allow configuring this within Laravel when using this transport.It also deduplicates logic shared between the Failover and RoundRobin transports, given they are mostly identical in terms of implementation. This includes ensuring their tests are both in
tests/Mail, rather thantests/Integration/Mail. If the latter variant was preferred, let me know and I'll replace it with a change the other way around.