Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct misspellings #55218

Merged
merged 2 commits into from
Mar 31, 2025
Merged

Correct misspellings #55218

merged 2 commits into from
Mar 31, 2025

Conversation

szepeviktor
Copy link
Contributor

Found few typos in method names.

@shaedrich
Copy link
Contributor

Since these are public methods, I wonder if this change can be made due to having to ensure backward compatibility 🤔

@AndrewMast
Copy link
Contributor

The method is only 5 months old (#53343). I'd prioritize the fixing of the typo, but maybe make an alias?

Fixing the typos in the test methods and files should be much less of an issue (if an issue at all)

@szepeviktor
Copy link
Contributor Author

I'd prioritize the fixing of the typo, but maybe make an alias?

Added.

@taylorotwell taylorotwell merged commit 8dfc3d4 into laravel:12.x Mar 31, 2025
39 checks passed
@szepeviktor szepeviktor deleted the typos-20250331 branch March 31, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@szepeviktor @shaedrich @AndrewMast @taylorotwell