fix: states eloquent scopes return affects query building #10301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
states that you need to use Model::query() if your scope has a void return
|
I don't know if this is the expected behavior, but @newtonjob has some good points that we could prevent this kind of confusion. |
|
Not sure if changing the docs is the right approach here. It's unfortunate that some devs have this problem right now in using the attribute, but this might be fixed soon when laravel/framework#55246 is merged, I'd assume. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
States that you need to use Model::query() if your scope has a void return.
Might cause some confusion, as the docs does not use the query() method and the scopes return is void.