Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Misskey and Mastodon forks #73

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

lime360
Copy link

@lime360 lime360 commented Jul 12, 2024

No description provided.

Copy link

vercel bot commented Jul 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
share2fedi ✅ Ready (Inspect) Visit Preview Jul 12, 2024 3:43pm

Copy link

netlify bot commented Jul 12, 2024

Deploy Preview for share2fedi ready!

Name Link
🔨 Latest commit d79208c
🔍 Latest deploy log https://app.netlify.com/sites/share2fedi/deploys/66914f138298c500087b9bc1
😎 Deploy Preview https://deploy-preview-73--share2fedi.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@kytta kytta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! There are more changes than just adding the names of the projects, though. Even if a project is a fork, it might use a different API and a different nodeinfo.

For S2F to work correctly, please

  • verify that it's /.well-known/nodeinfo is valid, and
  • the /.well-known/nodeinfo's software.name property is present
  • check that software.name is present in supportedProjects
  • if not, add it there, and check that the config works

It's also important to know that for now, because of the /instances endpoint, S2F only supports projects known to the Fediverse Observer. As of now, this does not include Chuckya or Iceshrimp. PR welcome to get rid of this limitation.

>)
</li>
<li>
Misskey (<span data-translate="incl">incl.</span>&#x0020;<span
data-enumerate="Firefish,Calckey,FoundKey,Meisskey"
>Firefish, Calckey, FoundKey, Meisskey</span
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Meisskey is not a typo, but a fork of Misskey. It might be unpopular, but we support it, so let's keep it in the list

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok

>)
</li>
<li>
Misskey (<span data-translate="incl">incl.</span>&#x0020;<span
data-enumerate="Firefish,Calckey,FoundKey,Meisskey"
>Firefish, Calckey, FoundKey, Meisskey</span
data-enumerate="Firefish(ex. Calckey),FoundKey,Misskey,Sharkey,Iceshrimp"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Did you verify that those actually work?

Adding a new project is more than just adding its name; even if it's just a fork.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah

@kytta kytta changed the title added 2 misskey forks and 1 mastodon forks because i feel like renewing the information about fediverse software Add new Misskey and Mastodon forks Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants