Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump go to v1.23 #11363

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

michaelbeaumont
Copy link
Contributor

Requires #11362

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Signed-off-by: Mike Beaumont <[email protected]>
@michaelbeaumont michaelbeaumont marked this pull request as ready for review September 9, 2024 21:41
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner September 9, 2024 21:41
@michaelbeaumont michaelbeaumont requested review from slonka and jakubdyszkiewicz and removed request for a team September 9, 2024 21:41
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) September 9, 2024 21:57
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't upgrade without modifying how we are installing golangci-lint as in other case make check will just freeze sucking all memory on macos

Edit#1: just checked and even when build go 1.23 from source golangci-lint is not working for me
Edit#2: after manually removing golangci-lint and running make dev/tools it started working

@michaelbeaumont michaelbeaumont merged commit 25091af into kumahq:master Sep 10, 2024
15 checks passed
@michaelbeaumont michaelbeaumont deleted the build/go-v1.23 branch September 10, 2024 08:52
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants