Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp): add possibility to omit top level targetRef in policies #11321

Merged
merged 9 commits into from
Sep 5, 2024

Conversation

Automaat
Copy link
Contributor

@Automaat Automaat commented Sep 5, 2024

Fixes: #10998

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@Automaat Automaat requested a review from a team as a code owner September 5, 2024 11:10
@Automaat Automaat requested review from michaelbeaumont and lukidzi and removed request for a team September 5, 2024 11:10
@Automaat Automaat merged commit 4d9ec2b into kumahq:master Sep 5, 2024
15 checks passed
@Automaat Automaat deleted the feat/top-level-optional branch September 5, 2024 18:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add possibility to omit spec.targetRef
2 participants