Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e/universal): copy container logs during e2e universal debug #11245

Merged
merged 1 commit into from
Aug 28, 2024
Merged

test(e2e/universal): copy container logs during e2e universal debug #11245

merged 1 commit into from
Aug 28, 2024

Conversation

bartsmykla
Copy link
Contributor

So far we didn't have access to logs of workloads in docker containers when e2e universal test fails. This commit copies files with logs to appropriate debug directory, which then is uploaded as an artifact via our CI.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues
    • No relevant issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS
    • It won't
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Locally tested
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md?
    • There is no need
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)
    • Only to 2.8

Changelog: skip

@bartsmykla
test(e2e/universal): copy container logs during e2e universal debug
b0c7656 
Sofar we didn't have access to logs of workloads in docker containers
when e2e universal test fails. This commit copies files with logs to
appropriate debug directory, which then is uploaded as an artifact via
our CI.

Signed-off-by: Bart Smykla <[email protected]>
@bartsmykla bartsmykla requested a review from a team as a code owner August 28, 2024 10:57
michaelbeaumont
michaelbeaumont approved these changes Aug 28, 2024
View reviewed changes
test/framework/debug.go Show resolved Hide resolved
@bartsmykla bartsmykla merged commit c18de01 into kumahq:master Aug 28, 2024
17 of 18 checks passed
@bartsmykla bartsmykla deleted the test/copy-logs-to-universal-e2e-debug branch August 28, 2024 11:36
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 28, 2024 •
edited
Loading

backporting to release-2.6 with action

backporting to release-2.8 with action
backporting to release-2.5 with action
backporting to release-2.4 with action

kumahq bot pushed a commit that referenced this pull request Aug 28, 2024
@bartsmykla @kumahq
test(e2e/universal): copy container logs during e2e universal debug (#…
51eaee1 
…11245)

Sofar we didn't have access to logs of workloads in docker containers
when e2e universal test fails. This commit copies files with logs to
appropriate debug directory, which then is uploaded as an artifact via
our CI.

Signed-off-by: Bart Smykla <[email protected]>
@kumahq kumahq bot mentioned this pull request Aug 28, 2024
Closed
kumahq bot pushed a commit that referenced this pull request Aug 28, 2024
@bartsmykla @kumahq
test(e2e/universal): copy container logs during e2e universal debug (#…
1bfd92e 
…11245)

Sofar we didn't have access to logs of workloads in docker containers
when e2e universal test fails. This commit copies files with logs to
appropriate debug directory, which then is uploaded as an artifact via
our CI.

Signed-off-by: Bart Smykla <[email protected]>
kumahq bot pushed a commit that referenced this pull request Aug 28, 2024
@bartsmykla @kumahq
test(e2e/universal): copy container logs during e2e universal debug (#…
babe49f 
…11245)

Sofar we didn't have access to logs of workloads in docker containers
when e2e universal test fails. This commit copies files with logs to
appropriate debug directory, which then is uploaded as an artifact via
our CI.

Signed-off-by: Bart Smykla <[email protected]>
This was referenced Aug 28, 2024
Merged
Closed
kumahq bot pushed a commit that referenced this pull request Aug 28, 2024
@bartsmykla @kumahq
test(e2e/universal): copy container logs during e2e universal debug (#…
9bfaa4b 
…11245)

Sofar we didn't have access to logs of workloads in docker containers
when e2e universal test fails. This commit copies files with logs to
appropriate debug directory, which then is uploaded as an artifact via
our CI.

Signed-off-by: Bart Smykla <[email protected]>
@kumahq kumahq bot mentioned this pull request Aug 28, 2024
Closed
kumahq bot pushed a commit that referenced this pull request Aug 28, 2024
@bartsmykla @kumahq
test(e2e/universal): copy container logs during e2e universal debug (#…
88b371d 
…11245)

Sofar we didn't have access to logs of workloads in docker containers
when e2e universal test fails. This commit copies files with logs to
appropriate debug directory, which then is uploaded as an artifact via
our CI.

Signed-off-by: Bart Smykla <[email protected]>
@kumahq kumahq bot mentioned this pull request Aug 28, 2024
Closed
bartsmykla pushed a commit that referenced this pull request Aug 28, 2024
@kumahq
test(e2e/universal): copy container logs during e2e universal debug (…
500bece 
…backport of #11245) (#11247)

Sofar we didn't have access to logs of workloads in docker containers
when e2e universal test fails. This commit copies files with logs to
appropriate debug directory, which then is uploaded as an artifact via
our CI.

Signed-off-by: Bart Smykla <[email protected]>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@Automaat Automaat Awaiting requested review from Automaat

@lukidzi lukidzi Awaiting requested review from lukidzi

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bartsmykla @michaelbeaumont @jakubdyszkiewicz