Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): rename ES resource name #11164

Merged
merged 1 commit into from
Aug 22, 2024
Merged

test(e2e): rename ES resource name #11164

merged 1 commit into from
Aug 22, 2024

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Aug 21, 2024

Checklist prior to review

We were using the some name of the ES resource in 2 places in e2e_env/kubernetes

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@lukidzi
test(e2e): rename ES resource name
f1ce049 
Signed-off-by: Lukasz Dziedziak <[email protected]>
@lukidzi lukidzi requested a review from a team as a code owner August 21, 2024 17:13
@lukidzi lukidzi requested review from jijiechen and bartsmykla and removed request for a team August 21, 2024 17:13
@lukidzi lukidzi merged commit 7e6788f into kumahq:master Aug 22, 2024
18 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 22, 2024 •
edited
Loading

backporting to release-2.4 with action

backporting to release-2.5 with action
backporting to release-2.6 with action
backporting to release-2.7 with action
backporting to release-2.8 with action

kumahq bot pushed a commit that referenced this pull request Aug 22, 2024
@lukidzi @kumahq
test(e2e): rename ES resource name (#11164)
9b0b14b 
Signed-off-by: Lukasz Dziedziak <[email protected]>
@kumahq kumahq bot mentioned this pull request Aug 22, 2024
Closed
kumahq bot pushed a commit that referenced this pull request Aug 22, 2024
@lukidzi @kumahq
test(e2e): rename ES resource name (#11164)
6a4350a 
Signed-off-by: Lukasz Dziedziak <[email protected]>
kumahq bot pushed a commit that referenced this pull request Aug 22, 2024
@lukidzi @kumahq
test(e2e): rename ES resource name (#11164)
35152b8 
Signed-off-by: Lukasz Dziedziak <[email protected]>
@kumahq kumahq bot mentioned this pull request Aug 22, 2024
Closed
kumahq bot pushed a commit that referenced this pull request Aug 22, 2024
@lukidzi @kumahq
test(e2e): rename ES resource name (#11164)
b942f0d 
Signed-off-by: Lukasz Dziedziak <[email protected]>
kumahq bot pushed a commit that referenced this pull request Aug 22, 2024
@lukidzi @kumahq
test(e2e): rename ES resource name (#11164)
1b71bec 
Signed-off-by: Lukasz Dziedziak <[email protected]>
This was referenced Aug 22, 2024
Closed
Merged
Merged
lukidzi added a commit that referenced this pull request Aug 22, 2024
@kumahq @lukidzi
test(e2e): rename ES resource name (backport of #11164) (#11171)
aa11df8 
test(e2e): rename ES resource name (#11164)

Signed-off-by: Lukasz Dziedziak <[email protected]>
Co-authored-by: Lukasz Dziedziak <[email protected]>
lukidzi added a commit that referenced this pull request Aug 22, 2024
@kumahq @lukidzi
test(e2e): rename ES resource name (backport of #11164) (#11170)
6216ff1 
Signed-off-by: Lukasz Dziedziak <[email protected]>
Co-authored-by: Lukasz Dziedziak <[email protected]>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@jijiechen jijiechen Awaiting requested review from jijiechen jijiechen is a code owner automatically assigned from kumahq/kuma-maintainers

@bartsmykla bartsmykla Awaiting requested review from bartsmykla bartsmykla is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukidzi @michaelbeaumont