Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): cleanup in test and increase time #11114

Merged
merged 7 commits into from
Aug 20, 2024

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Aug 14, 2024

Checklist prior to review

DismissCluster removes deployments but not namespaces. In the case of K8s, that can leave some resources that might impact others' k8s test stability since we create 2 k8s clusters at the start.

Because k8s cluster is shared, the control-plane deployment from the previous test is still there while the new control-plane is installed.

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
@lukidzi lukidzi added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Aug 14, 2024
@lukidzi lukidzi marked this pull request as ready for review August 19, 2024 17:01
@lukidzi lukidzi requested a review from a team as a code owner August 19, 2024 17:01
@lukidzi lukidzi requested review from bartsmykla and lobkovilya and removed request for a team August 19, 2024 17:01
@lukidzi lukidzi merged commit a34677d into kumahq:master Aug 20, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants