Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(insights): count new services as resources #11083

Conversation

jakubdyszkiewicz
Copy link
Contributor

Checklist prior to review

Adds counts of new services as resources field. It deprecates policies field.

If this gets merged, remember to create GUI issue so the GUI will change usage to the new field, so we can remove policies in 2 releases.

xref #11031
What's left is adding this to GlobalInsights, not sure what do we exactly need there.

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner August 9, 2024 15:15
@jakubdyszkiewicz jakubdyszkiewicz requested review from Automaat and Icarus9913 and removed request for a team August 9, 2024 15:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants