Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meshexternalservice): allow traffic when using egress, remove MTP support #11075

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Aug 8, 2024

Checklist prior to review

In a previous release, we added MeshExternalService (MES) support for dataplanes and egress. We decided that the top targetRef would select dataplanes, and for the purposes of MES and egress, we introduced this in that release. Since it's an experimental feature, we can safely remove it.

  • Remove MeshExternalService from topTargetRef (since it's experimental, we don't need to deprecate it: see MeshExternalService).
  • Add a default allow-all RBAC configuration on egress for MES, with an option to disable it for all MES.

Merge after #11073

@lukidzi lukidzi marked this pull request as ready for review August 9, 2024 12:02
@lukidzi lukidzi requested a review from a team as a code owner August 9, 2024 12:02
@lukidzi lukidzi requested review from Automaat, Icarus9913 and slonka and removed request for a team August 9, 2024 12:02
@lukidzi lukidzi merged commit e98f9ab into kumahq:master Aug 14, 2024
15 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants