Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #34

Closed
wants to merge 1 commit into from
Closed

Update README.md #34

wants to merge 1 commit into from

Conversation

wangxy518
Copy link

update some urls

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 22, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @wangxy518!

It looks like this is your first PR to kubernetes/kubernetes-template-project 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes-template-project has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wangxy518
To complete the pull request process, please assign nikhita
You can assign the PR to them by writing /assign @nikhita in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 22, 2020
@k8s-ci-robot k8s-ci-robot requested review from dims and parispittman May 22, 2020 02:22
@nikhita
Copy link
Member

nikhita commented May 22, 2020

@wangxy518 Thanks for the PR! The git.k8s.io links are intentional and are used to shorten links, so we'd want to keep using them in our docs and not replace with the full length github.com links.

Closing this PR since it's intentional, but thanks again.

/close

@k8s-ci-robot
Copy link
Contributor

@nikhita: Closed this PR.

In response to this:

@wangxy518 Thanks for the PR! The git.k8s.io links are intentional and are used to shorten links, so we'd want to keep using them in our docs and not replace with the full length github.com links.

Closing this PR since it's intentional, but thanks again.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants