Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add instructions to OWNERS #26

Merged
merged 1 commit into from
Nov 14, 2018
Merged

Conversation

BenTheElder
Copy link
Member

@BenTheElder BenTheElder commented Nov 14, 2018

Per discussion in #sig-testing slack, so as to not have steering suggested as approvers in every repo, project leads should be approvers instaed.

TODO: what should we put as the placeholder instead? I'm not sure if what I have is really suitable
Fixed, there are TODO comments now instead.

cc @spiffxp 🧔
cc @cblecker

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 14, 2018
@k8s-ci-robot k8s-ci-robot requested review from dims and philips November 14, 2018 00:06
@BenTheElder
Copy link
Member Author

/hold
d'oh, of course steering needs to be approvers in this repo, we should add instructions instead. fixing

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2018
@BenTheElder BenTheElder changed the title remove steering committee from owners add instructions to OWNERS Nov 14, 2018
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 14, 2018
@BenTheElder
Copy link
Member Author

/hold cancel
corrected

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2018
@philips
Copy link
Contributor

philips commented Nov 14, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, philips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2018
@k8s-ci-robot k8s-ci-robot merged commit aa40565 into kubernetes:master Nov 14, 2018
@BenTheElder BenTheElder deleted the sig-beard branch November 14, 2018 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants