Specify files which cannot include custom content #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spiffxp
reviewed
Sep 17, 2018
README.md
Outdated
| - a `SECURITY_CONTACTS` with the contact points for the Product Security Team | ||
| to reach out to for triaging and handling of incoming issues. They must agree to abide by the | ||
| [Embargo Policy](https://github.com/kubernetes/sig-release/blob/master/security-release-process-documentation/security-release-process.md#embargo-policy) | ||
| and will be removed and replaced if they violate that agreement. | ||
|
|
||
| The files `code-of-conduct.md` and `LICENSE` should not contain any custom content. |
There was a problem hiding this comment.
the
code-of-conduct.mdfrom this repo
I thought this was laid out above. Maybe specify in the list "an unmodified copy of code-of-conduct.md from this repo", and tack the no custom content onto the end of the LICENSE line?
Also, add a link to the Creative Commons 4.0 license from the website repo.
32b7106 to
ce0ef59
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, nikhita, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BenTheElder pointed out on slack that it would be nice to have a list of files which are allowed to have custom content and which do not.
This PR also adds a link to the Creative Commons 4.0 license from the website repo.
/committee steering
/cc @BenTheElder @spiffxp @cblecker
/assign @spiffxp