Fix kubectl plugin release

[alexintech]

What this PR does / why we need it:

Fixes build and release of the kubectl plugin using GitHub Actions and publishes updates to krew-index.
Fixes #12226 #10738

Since GoReleaser and krew-index require semantic version tags, the controller-vx.x.x tags violate SemVer. The GitHub Action has been modified to run only on tags prefixed with controller- and to extract only the vx.x.x part for versioning.

Some workarounds were implemented, such as setting the git tag within the pipeline because goreleaser release requires a valid SemVer tag in git. The release functionality of GoReleaser is not used, as it would create a new GitHub release without the controller- prefix. Instead, the softprops/action-gh-release action is used to upload artifacts to the existing release.

Another issue is that krew’s plugin manifest requires the version field to be a valid SemVer tag. The rajatjindal/krew-release-bot action uses {{ .Tag }} as the git tag when the action starts (controller-vx.x.x), which fails validation. To resolve this, the krew manifest generation has been changed to use GoReleaser’s Krew publish.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

fixes #12226
fixes #10738

How Has This Been Tested?

I have created test releases in a forked repository. See the controller-v1.12.1 release and the GitHub Action. A test PR to krew-index has been created by the GitHub Workflow.

The helm-4.12.1 release skips the workflow.

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.

[linux-foundation-easycla]

• ✅login: alexintech / (4c3ccbf)
• ✅login: alexintech / (4c3ccbf, 5991cf4)
• ✅login: alexintech / (4c3ccbf, 5991cf4, 1b520cd)
• ✅login: alexintech / (4c3ccbf, 5991cf4, 1b520cd, a262c32)
• ✅login: alexintech / (4c3ccbf, 5991cf4, 1b520cd, a262c32, 3e529f0)
• ✅login: alexintech / (4c3ccbf, 5991cf4, 1b520cd, a262c32, 3e529f0, 35835e7)
• ✅login: alexintech / (4c3ccbf, 5991cf4, 1b520cd, a262c32, 3e529f0, 35835e7, 6564f4b)
• ✅login: alexintech / (4c3ccbf, 5991cf4, 1b520cd, a262c32, 3e529f0, 35835e7, 6564f4b, 7ab3a37)
• ✅login: alexintech / (4c3ccbf, 5991cf4, 1b520cd, a262c32, 3e529f0, 35835e7, 6564f4b, 7ab3a37, e904aa8)
• ✅login: alexintech / (4c3ccbf, 5991cf4, 1b520cd, a262c32, 3e529f0, 35835e7, 6564f4b, 7ab3a37, e904aa8, b9d75d7)
• ✅login: alexintech / (4c3ccbf, 5991cf4, 1b520cd, a262c32, 3e529f0, 35835e7, 6564f4b, 7ab3a37, e904aa8, b9d75d7, d5ab169)
• ✅login: alexintech / (4c3ccbf, 5991cf4, 1b520cd, a262c32, 3e529f0, 35835e7, 6564f4b, 7ab3a37, e904aa8, b9d75d7, d5ab169, 2519739)

The committers listed above are authorized under a signed CLA.

[k8s-ci-robot]

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alexintech
Once this PR has been reviewed and has the lgtm label, please assign gacko for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @alexintech!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @alexintech. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name	Link
🔨 Latest commit	2519739
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/67ef73f9d68fee0008d1d1df

[Gacko]

I'm currently still at KubeCon in London, but I'd like to review this so we can have it in the next patch releases.

/hold