-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert change to mirror threshold #3727
Revert change to mirror threshold #3727
Conversation
Reverts part of kubernetes-sigs#3508 See kubernetes-sigs#3708; Envoy impl cannot meet this fine grain threshold.
Thanks @howardjohn! /lgtm Will also add a brief hold if anyone else wants to chime in, otherwise feel free to remove in ~24h |
/hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: howardjohn, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks, /cc @mhofstetter |
@LiorLieberman: GitHub didn't allow me to request PR reviews from the following users: mhofstetter. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/unhold |
Pickup kubernetes-sigs/gateway-api#3727 Very few changes between these versions
Pickup kubernetes-sigs/gateway-api#3727 Very few changes between these versions
* Bump Gateway API to remove flakes Pickup kubernetes-sigs/gateway-api#3727 Very few changes between these versions * fix lint
What type of PR is this?
/area conformance-test
What this PR does / why we need it:
Reverts part of #3508. This was a new change in 1.3
See #3708; Envoy impl cannot meet this fine grain threshold.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: