Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert change to mirror threshold #3727

Merged

Conversation

howardjohn
Copy link
Contributor

What type of PR is this?

/area conformance-test

What this PR does / why we need it:
Reverts part of #3508. This was a new change in 1.3

See #3708; Envoy impl cannot meet this fine grain threshold.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Reverts part of kubernetes-sigs#3508

See kubernetes-sigs#3708; Envoy
impl cannot meet this fine grain threshold.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. area/conformance-test Issues or PRs related to Conformance tests. labels Apr 3, 2025
@k8s-ci-robot k8s-ci-robot requested review from candita and kflynn April 3, 2025 17:56
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 3, 2025
@howardjohn
Copy link
Contributor Author

cc @LiorLieberman

@robscott
Copy link
Member

robscott commented Apr 3, 2025

Thanks @howardjohn!

/lgtm
/approve

Will also add a brief hold if anyone else wants to chime in, otherwise feel free to remove in ~24h

@robscott
Copy link
Member

robscott commented Apr 3, 2025

/hold

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: howardjohn, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 3, 2025
@LiorLieberman
Copy link
Member

Thanks,
/lgtm

/cc @mhofstetter

@k8s-ci-robot
Copy link
Contributor

@LiorLieberman: GitHub didn't allow me to request PR reviews from the following users: mhofstetter.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Thanks,
/lgtm

/cc @mhofstetter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@LiorLieberman
Copy link
Member

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 3, 2025
@k8s-ci-robot k8s-ci-robot merged commit 850b408 into kubernetes-sigs:main Apr 3, 2025
13 checks passed
howardjohn added a commit to howardjohn/istio that referenced this pull request Apr 4, 2025
Pickup kubernetes-sigs/gateway-api#3727

Very few changes between these versions
howardjohn added a commit to howardjohn/istio that referenced this pull request Apr 7, 2025
Pickup kubernetes-sigs/gateway-api#3727

Very few changes between these versions
istio-testing pushed a commit to istio/istio that referenced this pull request Apr 7, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Bump Gateway API to remove flakes

Pickup kubernetes-sigs/gateway-api#3727

Very few changes between these versions

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants