Updating deps to k8s 1.32 and go 1.24 #3697
Conversation
Co-authored-by: dtumkursreenivas <[email protected]>
3895ec9 to
8e22341
Compare
There was a problem hiding this comment.
Thanks for making this one happen Rob.
In terms of dependencies, seems like the new crd-ref-docs is an improvement.
/approve
I only have one comment about leaving a breadcrumb behind for the upstream issue that caused us to add a hack, other than that LGTM.
/lgtm
Just gonna put a hold in case there's any last minute touchups you wanna do, otherwise please feel free to remove the hold at your discretion. 🫡
/hold
| @@ -109,6 +113,12 @@ go run k8s.io/code-generator/cmd/register-gen \ | |||
| ${COMMON_FLAGS} \ | |||
| ${GATEWAY_INPUT_DIRS_SPACE} | |||
|
|
|||
| # This is an awful hack to make up for a deficiency in register-gen in k8s v1.32 | |||
There was a problem hiding this comment.
Is there an issue related to this problem that we can link here?
There was a problem hiding this comment.
This is a bit of a circular problem where I want to be able to link to this in the k/k issue as an illustration of the problem and solution. Will add a k/k issue link after that, but would like to merge this first.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Have some follow up fixes to get in, but want to get this one in first since it's so big. /hold cancel |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This updates our dependencies to Kubernetes v1.32 and Go v1.24. This is a follow up to #3694, thanks to @darshansreenivas for starting the work here! This is our last release blocking issue and we really want to get a release out this week, so going to attempt to help get this across the line.
Which issue(s) this PR fixes:
Fixes #3623
Does this PR introduce a user-facing change?: