Removing outdated Experimental Gateway API CRDs #3692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardjohn
approved these changes
Mar 19, 2025
There was a problem hiding this comment.
LGTM. I have some more fixes in #3691 you don't have, but you have more fixes than I have as well 😛 . So will rebase on yours once merged
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: howardjohn, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
85cd7ff to
d17b99d
Compare
d17b99d to
d271d79
Compare
d271d79 to
52d6096
Compare
52d6096 to
00ea1a9
Compare
|
LGTM but adding it now will just removed when you push to fix the tests. |
* ListenerSet was never released, has been replaced with XListenerSet * BackendLBPolicy has been replaced with BackendTrafficPolicy
00ea1a9 to
90cc735
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Our CRD generation changes only ever add CRDs, they never remove unnecessary ones. This was evident in #3682. Thanks to @howardjohn for catching this in #3682 (comment). This PR removes the following CRDs:
Does this PR introduce a user-facing change?: