Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEP-2627 DNS Policy #2712
base: main
Are you sure you want to change the base?
GEP-2627 DNS Policy #2712
Changes from all commits
330a1de
f3c86ee
ac54f7e
c56f690
2f42d0f
46615d1
43f18b4
97260fb
b756fda
c173258
b4a8d77
f12d2e5
256c622
c08c3fb
970f17a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't cover any application developer user stories here, we seem pretty focused on the cluster administrator. I anticipate that application developers will in fact will have relevant use cases. What are your thoughts on application developer roles needs here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am struggling a little to think of specific application developer use cases around this. What comes to mind is allowing the DNSPolicy to potentially target a HTTPRoute or possibly some form of health check based on the available endpoints behind a service. So as an attempt at a use case "As an application developer, I do not want my service to be exposed via the Gateway until there are pods that are healthy and ready to serve the traffic" ? Did you have anything specific in mind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kflynn, @mlavacca, @arkodg curious if you have any thoughts here?