feat: Make compatible with duckdb 0.7 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In version 0.7, duckdb removed DuckDBResult, merging it with DuckDBPyConnection. Now this lib works with duckdb >=0.7
Before, if I tried to install this package using pip I would get
`pip install .`
Obtaining file:///Users/nickcrews/Documents/projects/aioduckdb
Installing build dependencies ... done
Checking if build backend supports build_editable ... done
Getting requirements to build editable ... done
Preparing editable metadata (pyproject.toml) ... error
error: subprocess-exited-with-error
× Preparing editable metadata (pyproject.toml) did not run successfully.
│ exit code: 1
╰─> [20 lines of output]
Traceback (most recent call last):
File "/Users/nickcrews/Documents/projects/aioduckdb/.venv/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
main()
File "/Users/nickcrews/Documents/projects/aioduckdb/.venv/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
json_out['return_val'] = hook(**hook_input['kwargs'])
File "/Users/nickcrews/Documents/projects/aioduckdb/.venv/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 181, in prepare_metadata_for_build_editable
return hook(metadata_directory, config_settings)
File "/private/var/folders/nz/wfwcn6md1796t48tx9dhf0v40000gn/T/pip-build-env-r2wy84sq/overlay/lib/python3.10/site-packages/flit_core/buildapi.py", line 49, in prepare_metadata_for_build_wheel
metadata = make_metadata(module, ini_info)
File "/private/var/folders/nz/wfwcn6md1796t48tx9dhf0v40000gn/T/pip-build-env-r2wy84sq/overlay/lib/python3.10/site-packages/flit_core/common.py", line 410, in make_metadata
md_dict.update(get_info_from_module(module, ini_info.dynamic_metadata))
File "/private/var/folders/nz/wfwcn6md1796t48tx9dhf0v40000gn/T/pip-build-env-r2wy84sq/overlay/lib/python3.10/site-packages/flit_core/common.py", line 207, in get_info_from_module
docstring, version = get_docstring_and_version_via_import(target)
File "/private/var/folders/nz/wfwcn6md1796t48tx9dhf0v40000gn/T/pip-build-env-r2wy84sq/overlay/lib/python3.10/site-packages/flit_core/common.py", line 180, in get_docstring_and_version_via_import
spec.loader.exec_module(m)
File "<frozen importlib._bootstrap_external>", line 883, in exec_module
File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
File "/Users/nickcrews/Documents/projects/aioduckdb/aioduckdb/__init__.py", line 6, in <module>
from duckdb import ( # pylint: disable=redefined-builtin
ModuleNotFoundError: No module named 'duckdb'
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed
× Encountered error while generating package metadata.
╰─> See above for output.
note: This is an issue with the package mentioned above, not pip.
hint: See above for details.
This is because during the wheel build process we actually need duckdb.
Now installs work with pip. I assume this
wasn;t coming up before because people were building
with flit inside a dev environment that
had duckdb?? IDK exactly. But now it works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 0.7, duckdb removed DuckDBResult, merging it with DuckDBPyConnection. Now this lib works with duckdb >=0.7