Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added exports.default to package.json #1630

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

daleyjem
Copy link
Contributor

@daleyjem daleyjem commented Jan 10, 2022

Per NodeJS documentation on the package.json exports object, there seems to be a need for a fallback default key:
https://nodejs.org/api/packages.html#conditional-exports

Additionally, I'm seeing things like eslint fail to resolve until a default key has been specified. I've not dug any further into why, but I think some default should be defined until more options should later be added.

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #1630 (ec8de58) into master (8c1dd48) will not change coverage.
The diff coverage is n/a.

❗ Current head ec8de58 differs from pull request most recent head e5617c1. Consider uploading reports for the commit e5617c1 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1630   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files           5        5           
  Lines         507      507           
  Branches      142      142           
=======================================
  Hits          505      505           
  Misses          2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c1dd48...e5617c1. Read the comment docs.

@jeremy-daley-kr
Copy link

@3imed-jaberi Who has the ability to merge this?

@kevinpeno kevinpeno force-pushed the feature/package-exports-default branch from e5617c1 to bddafea Compare October 20, 2024 22:18
@kevinpeno kevinpeno force-pushed the feature/package-exports-default branch from bddafea to 2e38a4a Compare October 20, 2024 22:20
@kevinpeno
Copy link
Contributor

@jonathanong should be gtg now, if its something we want merged.

@kevinpeno kevinpeno self-assigned this Oct 20, 2024
@jonathanong jonathanong merged commit ff0f3b6 into koajs:master Oct 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants