Enable multisig for account #1476
Merged
+313
−180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4a2a524
to
d8a0258
Compare
d8a0258
to
ff9d3e3
Compare
obatirou
reviewed
Oct 8, 2024
obatirou
previously approved these changes
Oct 8, 2024
ClementWalter
commented
Oct 8, 2024
enitrat
pushed a commit
that referenced
this pull request
Oct 9, 2024
Time spent on this PR: 0.5 Please check the type of change your PR introduces: - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): Not possible to use an Argent multisig account as account in the scripts. Resolves #1411 - `get_starknet_account` can handle an Argent multisig account as sender. - all invoke tx now use the same `execute_v1` function extracted from `starknet-py`. - this function can be lazy and batch execute calls afterwards instead of executing them when called. - also added cache of the class_hashes at compile step to speed up the deployment script. <!-- Reviewable:start --> - - - This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/kkrt-labs/kakarot/1476) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent on this PR: 0.5
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Not possible to use an Argent multisig account as account in the scripts.
Resolves #1411
What is the new behavior?
get_starknet_accountcan handle an Argent multisig account as sender.execute_v1function extracted fromstarknet-py.This change is