Ci integration #36
Merged
Ci integration #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f148d19 to
ce7a757
Compare
Investigating TestLoadProperties error seems to show a behavior difference in the comparison method. I fixed the test to it works, it seems like the 'loadPropertiesFromInput' is indeed doing what it's supposed to do.
ce7a757 to
5370f20
Compare
pierre
approved these changes
Mar 12, 2023
kbcmd/cmdlib/args/property_test.go
Outdated
| return e == TestEnumFOO | ||
| } | ||
|
|
||
| type testObj2 struct { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new GH Action suite to run the integration test suite against a KB docker deployment.
This also fixes a couple of incorrect remaining
v2packages and an issue with one thekbcmdtest.Note: I thought I had removed the circleCI but I am still seeing it.