Skip to content

Conversation

@tonyteate
Copy link
Contributor

📲 What

  • Broaden Intent filtering when Action is MAIN
  • Include logging via Crashlytics for when Categories is null

🤔 Why

There is a non-fatal bug in the Splash Screen that can cause the screen to hang. While the bug is real in and of itself, the fact that we’re seeing it implies that the app is possibly being launched in an unconventional manner.

🛠 How

Handle the bug, unconventional launches, and leverage Firebase to collect and verify some information about the unconventional nature of those launches.

👀 See

N/A

📋 QA

  • Launch the app from the app drawer and confirm it moves past the Splash Screen

  • Run the following command and confirm the app opens and moves past the Splash Screen:

    adb shell 'am start -a android.intent.action.MAIN com.kickstarter.kickstarter.internal.debug'
    
    • Note: Try this same command on the previous version to see the screen hang.

Story 📖

[MBL-2926] Let Splash Screen handle Main Intent without Categories - Jira

- Include logging via Crashlytics for when Categories is `null`
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.21%. Comparing base (0dd085b) to head (c0a714a).

Files with missing lines Patch % Lines
...om/kickstarter/viewmodels/SplashScreenViewModel.kt 33.33% 5 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2457      +/-   ##
============================================
- Coverage     64.22%   64.21%   -0.01%     
  Complexity     2401     2401              
============================================
  Files           378      378              
  Lines         28736    28743       +7     
  Branches       4146     4145       -1     
============================================
+ Hits          18455    18458       +3     
- Misses         8022     8027       +5     
+ Partials       2259     2258       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tonyteate tonyteate merged commit 6e6f03e into master Dec 9, 2025
3 checks passed
@tonyteate tonyteate deleted the tony/mbl-2926 branch December 9, 2025 15:12
tonyteate added a commit that referenced this pull request Dec 9, 2025
- Include logging via Crashlytics for when Categories is `null`

Co-authored-by: Tony Teate <[email protected]>

(cherry picked from commit 6e6f03e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants