Skip to content

Conversation

@Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Oct 16, 2025

📲 What

  • Fixing AddOns visible (no available to pledge) on addOns screen.
    The screenshot shows how an add-On(Time sensitive add-on!) which starting date is on 26-10-2025 is displayed but does not allow to proceed with checkout.
Screenshot 2025-10-16 at 11 55 58 AM

🤔 Why

  • The HRC2 creator reported that several add-ons that they have not yet set live are visible for users in the Android app (see screenshot).

🛠 How

  • Filtering locally on the app the addOns list, long term solution to avoid similar issues moving forward will be applied during mobile visioning.

👀 See

| Before 🐛 |

On this video you see the addOn “Time sensitive add-on!“ This add-On start date is 26-10-2025, therefore should not be shown!!.

ShowingAddOnTimeSensitive.mp4

|After 🦋 |

On this video you see the addOn “Time sensitive add-on!“ does not appear on the list
https://github.com/user-attachments/assets/e6a25c6d-016f-46ec-b835-5f1e53cc0a73

| --- | --- |
| | |

📋 QA

On Staging load project Tween Podcast Sandwich → Filter location by Canada → Choose “reward shipping everywhere” → On addOns screen scroll to the very end. Here you should not see the addOn “Time sensitive add-on!“ (This add-On should start date is 26-10-2025.)

not_available_addOn.mp4

Story 📖

SD-4413

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.65%. Comparing base (d71ff7e) to head (1b4d235).

Files with missing lines Patch % Lines
...ain/java/com/kickstarter/libs/utils/RewardUtils.kt 50.00% 0 Missing and 1 partial ⚠️
...kstarter/viewmodels/projectpage/AddOnsViewModel.kt 50.00% 0 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2431   +/-   ##
=========================================
  Coverage     64.64%   64.65%           
- Complexity     2389     2392    +3     
=========================================
  Files           376      376           
  Lines         28451    28453    +2     
  Branches       4120     4120           
=========================================
+ Hits          18393    18395    +2     
  Misses         7800     7800           
  Partials       2258     2258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Arkariang Arkariang self-assigned this Oct 16, 2025
@Arkariang Arkariang marked this pull request as ready for review October 16, 2025 23:03
Copy link
Contributor

@tonyteate tonyteate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@Arkariang Arkariang merged commit ab864c4 into master Oct 20, 2025
3 checks passed
@Arkariang Arkariang deleted the imartin/SD-4413-available-addOn-bug branch October 20, 2025 20:09
Arkariang added a commit that referenced this pull request Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants