Skip to content

Conversation

@Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Sep 3, 2025

📲 What

  • The video started playing after navigating back to the project page from other activities such as Updates, Comments ...

🤔 Why

  • reset the videoplayer after lifecycle events, but playwhenready flag was set to true always.

🛠 How

  • changed initialization/release of the videoplayer (there is only 1 instance now).
  • added a bit extra logic around playwhenready flag
  • ℹ️ bare minimum to fix the bug, as we will tackle project page during visioning.

👀 See

| Before 🐛 |

before.mp4

|After 🦋 |

https://github.com/user-attachments/assets/92e539ac-3a78-4346-ad46-8cd44f0ff94d
| --- | --- |
| | |

📋 QA

  • Play a video, navigate to other activities, navigate back to project page.

Story 📖

MBL-2729

@Arkariang Arkariang self-assigned this Sep 3, 2025
@Arkariang Arkariang marked this pull request as ready for review September 3, 2025 15:58
Copy link
Contributor

@ycheng-kickstarter ycheng-kickstarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.69%. Comparing base (fed6d75) to head (d148dea).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2416      +/-   ##
============================================
+ Coverage     64.66%   64.69%   +0.02%     
- Complexity     2405     2407       +2     
============================================
  Files           375      375              
  Lines         28432    28432              
  Branches       4123     4123              
============================================
+ Hits          18386    18394       +8     
+ Misses         7782     7773       -9     
- Partials       2264     2265       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Arkariang Arkariang merged commit 14bb037 into master Sep 4, 2025
3 checks passed
@Arkariang Arkariang deleted the imartin/MBL-2729 branch September 4, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants