Skip to content

Conversation

@Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Aug 12, 2025

📲 What

  • Dependencies upgrades

🤔 Why

  • Always up to date!

🛠 How

  • Upgraded dependencies (as much as possible until hitting kotlin version restriction), do some QA.

👀 See

  • No user facing changes!
    | --- | --- |
    | | |

📋 QA

  • QA for stripe, add new payment method/delete payment method, pledge to crowdfund, pledge on late pledges
  • QA for lottie, run our beautiful onboarding
  • QA for joda, compare 1-1 with other build/branch check on project cards on search/discovery the time tags ( X days left, or X hours left ...)

Story 📖

MBL-2708

Arkariang added 30 commits May 26, 2025 10:30
…starter/android-oss into imartin/migrate-to-media3-exoplayer
…starter/android-oss into imartin/migrate-to-media3-exoplayer
- using now 1.8.0
- Tabs library
- Old UI libraries
- internal tools library
- testing library
- core-runtime libreries
- jsoup for parser
- desugaring java
@Before
fun init() {
// - DateTimeZone.forID("EST")) requires initializing joda time library, on newest versions the initializing method has been deprecated look for an alternative
JodaTimeAndroid.init(context())
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated, it is self initializing now

"Dec 17, 2015, 1:35:05 PM",
DateTimeUtils.mediumDateTime(
DateTime.parse("2015-12-17T18:35:05Z"),
DateTimeZone.forID("EST")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"EST" no longer recognized as ID, to assert for that time zone:
DateTimeZone.forOffsetHours() if it’s always fixed UTC−5, the offset in hours to check for "EST"

kapt "com.google.dagger:dagger-compiler:$dagger_version"
implementation 'com.jakewharton:process-phoenix:3.0.0'
implementation "com.jakewharton.timber:timber:5.0.1"
implementation 'com.stripe:stripe-android:20.47.3'
Copy link
Contributor Author

@Arkariang Arkariang Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

21.7.1 is the latest, but cannot go that high, requires kotlin version upgrades

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.67%. Comparing base (0b2d0f0) to head (9baa372).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2402   +/-   ##
=========================================
  Coverage     64.67%   64.67%           
  Complexity     2404     2404           
=========================================
  Files           376      376           
  Lines         28421    28421           
  Branches       4122     4122           
=========================================
  Hits          18382    18382           
  Misses         7777     7777           
  Partials       2262     2262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Arkariang Arkariang marked this pull request as ready for review August 12, 2025 18:12
@Arkariang Arkariang self-assigned this Aug 12, 2025
@Arkariang Arkariang requested review from leighdouglas, tonyteate and ycheng-kickstarter and removed request for ycheng-kickstarter August 12, 2025 18:12
@tonyteate
Copy link
Contributor

tonyteate commented Aug 20, 2025

  • Onboarding ✅
  • Discovery & Search time calculation & display ✅
  • Adding/Deleting a payment method from Settings ✅
  • Pledging to Crowdfund & Late Pledge Projects with an existing card ✅

As of now the only case that fails is adding a new card during the pledge flow:

Screen_recording_20250820_111601.mp4

@Arkariang
Copy link
Contributor Author

com.stripe:stripe-android:20.47.3

Got it!
thanks for catching this one tony! will require some work to fix, so reverting for now to the versions we were using before, and added a new ticket. Now that version kotlin has been updated we can deal with all together for stripe -> https://kickstarter.atlassian.net/browse/MBL-2733

@Arkariang Arkariang merged commit 363117b into master Aug 20, 2025
3 checks passed
@Arkariang Arkariang deleted the imartin/requires-qa branch August 20, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants