-
Notifications
You must be signed in to change notification settings - Fork 997
MBL-2708: upgrade more dependencies #2402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tin/migrate-to-media3-exoplayer
…tin/migrate-to-media3-exoplayer
…starter/android-oss into imartin/migrate-to-media3-exoplayer
…tin/migrate-to-media3-exoplayer
…starter/android-oss into imartin/migrate-to-media3-exoplayer
- using now 1.8.0
- Tabs library - Old UI libraries
- internal tools library - testing library - core-runtime libreries
…tin/upgrades # Conflicts: # app/build.gradle # build.gradle # gradle/wrapper/gradle-wrapper.properties
| @Before | ||
| fun init() { | ||
| // - DateTimeZone.forID("EST")) requires initializing joda time library, on newest versions the initializing method has been deprecated look for an alternative | ||
| JodaTimeAndroid.init(context()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecated, it is self initializing now
| "Dec 17, 2015, 1:35:05 PM", | ||
| DateTimeUtils.mediumDateTime( | ||
| DateTime.parse("2015-12-17T18:35:05Z"), | ||
| DateTimeZone.forID("EST") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"EST" no longer recognized as ID, to assert for that time zone:
DateTimeZone.forOffsetHours() if it’s always fixed UTC−5, the offset in hours to check for "EST"
| kapt "com.google.dagger:dagger-compiler:$dagger_version" | ||
| implementation 'com.jakewharton:process-phoenix:3.0.0' | ||
| implementation "com.jakewharton.timber:timber:5.0.1" | ||
| implementation 'com.stripe:stripe-android:20.47.3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
21.7.1 is the latest, but cannot go that high, requires kotlin version upgrades
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2402 +/- ##
=========================================
Coverage 64.67% 64.67%
Complexity 2404 2404
=========================================
Files 376 376
Lines 28421 28421
Branches 4122 4122
=========================================
Hits 18382 18382
Misses 7777 7777
Partials 2262 2262 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
As of now the only case that fails is adding a new card during the pledge flow: Screen_recording_20250820_111601.mp4 |
Got it! |
📲 What
🤔 Why
🛠 How
👀 See
| --- | --- |
| | |
📋 QA
Story 📖
MBL-2708