Skip to content

Conversation

@Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Jul 29, 2025

📲 What

  • On android 16 devices, Glide seems to require the header userAgent to load images

🤔 Why

  • Images not loading on Android 16 devices

🛠 How

  • Added a lazyHeader containing the custom user agent we use for the apps

👀 See

| Before 🐛 |

glideIssue.mp4

| After 🦋 |

GlideImagesLoading.mp4

| --- | --- |
| | |

📋 QA

  • You need an android 16 device, or a simulator, then just open the app, images with this branch should load again without issues

Story 📖

MBL-2671

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.30%. Comparing base (a93894c) to head (37372a0).

Files with missing lines Patch % Lines
...java/com/kickstarter/ui/extensions/ImageViewExt.kt 0.00% 40 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2394      +/-   ##
============================================
- Coverage     66.38%   66.30%   -0.09%     
+ Complexity     2349     2348       -1     
============================================
  Files           378      378              
  Lines         27904    27938      +34     
  Branches       4230     4232       +2     
============================================
- Hits          18524    18523       -1     
- Misses         7118     7152      +34     
- Partials       2262     2263       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


fun userAgent(context: Context) = if (context.applicationContext.isKSApplication()) {
val build = requireNotNull(context.applicationContext.getEnvironment()?.build())
WebUtils.userAgent(build)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uses the custom user agent we build for every network request

@Arkariang Arkariang marked this pull request as ready for review July 29, 2025 22:50
@Arkariang Arkariang self-assigned this Jul 29, 2025
@Arkariang Arkariang merged commit f454e4e into master Jul 29, 2025
3 checks passed
@Arkariang Arkariang deleted the imartin/MBL-2671-android16-glide-issue branch July 29, 2025 23:07
Arkariang added a commit that referenced this pull request Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants