MBL-2609: Edge case - empty address modal on survey_submitted cards when creator has not turned on address collection #2387
+36
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2387 +/- ##
=========================================
Coverage ? 66.38%
Complexity ? 2349
=========================================
Files ? 378
Lines ? 27904
Branches ? 4230
=========================================
Hits ? 18524
Misses ? 7118
Partials ? 2262 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tonyteate
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
We discovered an edge case - if a creator sends out a survey without turning on address collection unintentionally, and the backer submits the survey without their address, but their backing includes a shippable reward, the address card will be blank. We shouldnt hide the modal, but alert the user to notify the creator to resolve the issue.
🤔 Why
This is a very very small edge case that really shouldn't happen, and hasn't really happened, but could happen, so we should account for it.
🛠 How
When the address on the backing is null, we surface text to the backer notifying them to contact the creator.
👀 See
📋 QA
This is a complex edge to QA, but PM and I can try and find a test account with a pledge in this state.
Story 📖
MBL-2609: Edge case - empty address modal on survey_submitted cards when creator has not turned on address collection