MBL-2617: Empty states #2381
MBL-2617: Empty states #2381
Conversation
…tin/MBL-2615-action-on-pills # Conflicts: # app/src/main/java/com/kickstarter/ui/activities/compose/search/FilterMenuSheet.kt # app/src/main/java/com/kickstarter/ui/activities/compose/search/SearchTopBar.kt # app/src/test/java/com/kickstarter/ui/activities/compose/search/SearchTopBarTest.kt
…tin/MBL-2617-empty-states
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2381 +/- ##
============================================
- Coverage 66.18% 66.16% -0.03%
- Complexity 2345 2346 +1
============================================
Files 377 377
Lines 27593 27653 +60
Branches 4181 4191 +10
============================================
+ Hits 18263 18297 +34
- Misses 7094 7119 +25
- Partials 2236 2237 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| ) { | ||
| val mod = if (shouldWrapContentWidth) | ||
| modifier.wrapContentWidth() | ||
| else modifier.fillMaxWidth() |
There was a problem hiding this comment.
Quite probably for our design system health we should not set width for buttons within the button itself, but on the modifier outside of the button itself, (fyi: modifiers in compose do follow the builder pattern, if we setup with within the button itself it will be the latest one applied)
Will add a follow up design system refactor ticket for this specific point to not set fillMaxWidth() nor wrapContentWidth() within the button component. Adding this solution temporarily to not hold any release
📲 What
Search & filter UI empty states polishes
👀 See
EmptyStates.mp4
| --- | --- |
| | |
📋 QA
Story 📖
MBL-2617