MBL-2594 [Edit PLOT]. FF disabled- The choose another reward flow should not allow changing collection plans. #2368
+12
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2368 +/- ##
=========================================
Coverage 67.26% 67.26%
- Complexity 2340 2341 +1
=========================================
Files 375 375
Lines 26658 26658
Branches 4030 4031 +1
=========================================
+ Hits 17931 17932 +1
Misses 6544 6544
+ Partials 2183 2182 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leighdouglas
approved these changes
Jul 4, 2025
leighdouglas
pushed a commit
that referenced
this pull request
Jul 4, 2025
…uld not allow changing collection plans. (#2368) fix collection plan for FF off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Hide collection plan when FF off and choose another reward is selected for a pledge in full payment selected before
🤔 Why
The choose another reward flow should not allow changing collection plans.
🛠 How
Fixed the validation for show collection plan or not adding the FF for edit pledge to the equation
SEE
video_proof.webm
📋 QA
Turn off feature flag for edit pledge
Do the pledge flow on Crossfit Video Game Think Tank https://staging.kickstarter.com/projects/1466322202/crossfit-video-game-think-tank?ref=android_project_share
on the manage pledge menu select choose another reward
on the checkoutscreen collection plan should not be shown
Story 📖
MBL-2594