-
Notifications
You must be signed in to change notification settings - Fork 996
MBL-2585 [Edit PLOT- FF disabled] The standard promise does not display the edit option #2367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2367 +/- ##
=========================================
Coverage 67.26% 67.26%
- Complexity 2340 2341 +1
=========================================
Files 375 375
Lines 26647 26658 +11
Branches 4027 4030 +3
=========================================
+ Hits 17924 17932 +8
- Misses 6543 6544 +1
- Partials 2180 2182 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
app/src/main/java/com/kickstarter/ui/helpers/ManagePledgeMenuOptionsFactory.kt
Show resolved
Hide resolved
app/src/main/java/com/kickstarter/ui/helpers/ManagePledgeMenuOptionsFactory.kt
Show resolved
Hide resolved
…ptionsFactory.kt Co-authored-by: jovaniks <[email protected]>
…ptionsFactory.kt Co-authored-by: jovaniks <[email protected]>
| android:title="@string/Edit_pledge" | ||
| app:showAsAction="never"/> | ||
| <item android:id="@+id/choose_another_reward" | ||
| android:title="@string/Choose_another_reward" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If wanted to avoid adding more items to the menu, you could simple change the title programatically, as at the end of the day as jovani mentions in his comments we do need to always present the menu option with only 1 exception when the ffOff for plot projects
Arkariang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved as I've tested it and brings back the menu + there is tests around it 💟 , though we can definitely clean up here:
1 - remove PLOT feature flag (as been released for several months already).
2 - no need to have a different menu item, we can always change the title programatically if required different strings depending on plot/non-plot .
So I'll suggest write the clean up ticket and bring it to the sprint as soon as we get this release out!
…ay the edit option (#2367) * Fix menu options for plot and non plot to show choose another reward opt * delete unecesary log * Update app/src/main/java/com/kickstarter/ui/helpers/ManagePledgeMenuOptionsFactory.kt Co-authored-by: jovaniks <[email protected]> * Update app/src/main/java/com/kickstarter/ui/helpers/ManagePledgeMenuOptionsFactory.kt Co-authored-by: jovaniks <[email protected]> * added tests --------- Co-authored-by: jovaniks <[email protected]>
📲 What
Fix the choose another reward option on new manage pledge menu to be shown when FF is off
🤔 Why
On the refactor of the menu for manage pledge the choose another reward was deleted in order to use the Edit Pledge option, but when feature flag is off it should appear and when ff is on it should appear for non-plot projects
🛠 How
👀 See
ff_off_non_plot.webm
ff_off_plot.webm
ff_on_non_plot_project.webm
ff_on_plot_project.webm
📋 QA
Check the render of the menu depending on the feature flag status. This is the matrix:
Feature Flag: OFF
Feature Flag: ON
Story 📖
MBL-2585