Passing Rspec Tests and Rubyzip upgrade#34
Open
jgrahamthomas wants to merge 8 commits intojugyo:masterfrom
Open
Passing Rspec Tests and Rubyzip upgrade#34jgrahamthomas wants to merge 8 commits intojugyo:masterfrom
jgrahamthomas wants to merge 8 commits intojugyo:masterfrom
Conversation
… signature. Gets rspect tests to pass.
…d fonts on ibooks
Explains what's been enhanced.
New Readme baby
agilecreativity
added a commit
to agilecreativity/eeepub
that referenced
this pull request
Oct 5, 2014
… merge - Update the dependencies gem to the most recent version - Update the code for 'rubyzip' gem for the newer version - Commented out the code that cause the rake to fail. - Be specific about the gem dependencies - Update the gitignore file - This gem will be deprecated when the original author merge the PR (jugyo#34)
agilecreativity
added a commit
to agilecreativity/eeepub
that referenced
this pull request
Apr 4, 2016
- Make use of optermistic gem locking - Update some gem's dependencies - Add some code from the [PR#14](jugyo#34) - Minore code cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've modified the rspec test suite to get tests to pass. I've also made a couple of tweaks to make the OCF libraby compatible with the latest version of rubyzip (1.1.0).