Fix deltaFactor for old webkits #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When delta is more than or equal to 120 - we devide it by 40 to get delta in pixels.
|
I forget that wheelDelta property doesn't always start out at its lowest number like the newer deltaY property seems to do. |
|
I took a slightly different approach to fixing this. I also added a setting to allow people to turn this particular normalizing behavior off. Try out the 3.1.9 release and let me know how it works for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When delta is more than or equal to
120- we devide it by40to get delta in pixels.If we check only for delta being equal to
120we getdeltaFactorequal to240sometimes.https://www.monosnap.com/file/OXQ113pLoDnYCFDbiQDhZO0ceKXzfE