Skip to content

Added basic ie8 support #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

bencooling
Copy link

Added basic support for deltaY and deltaX values for ie8, bringing it inline with ie9. Tested on Mac with Browsers: Chrome 27, Firefox 21, Safari 6 & a Windows 7 VM running ie8, ie9.

@bencooling
Copy link
Author

Please note my fix only supports vertical scrolling. ie8 & less doesn't seem to register the xaxis scrolling event. See: http://stackoverflow.com/questions/10821985/detecting-mousewheel-on-the-x-axis-left-and-right-with-javascript

@blueprintmrk
Copy link

try http://www.browserstack.com/ for testing most Browsers

@brandonaaron
Copy link
Contributor

The idea was that if the browser didn't support reporting the event on a different axis, then it wouldn't update those values. Seems as though I should go back to the previous logic of always setting deltaY even if the browser doesn't report a deltaY.

@brandonaaron
Copy link
Contributor

Closing in favor of #74.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants