Build: Add jtr-based tests in GitHub Actions, migrate to ESLint flat config #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a .editorconfig as well? |
…config Changes: * Migrate from Karma to jquery-test-runner * Add tests on real browsers * Run tests on GitHub Actions * Migrate ESLint from v7 to v9 with a flat config * Switch from UglifyJS to SWC, enforce ES 5 * Add `.editorconfig` & `.gitattributes` files * Update `.gitignore` to include more patterns from jQuery Core
@timmywil done; I also added |
timmywil
approved these changes
Mar 13, 2025
mgol
added a commit
that referenced
this pull request
Mar 13, 2025
…config Changes: * Migrate from Karma to jquery-test-runner * Add tests on real browsers * Run tests on GitHub Actions * Migrate ESLint from v7 to v9 with a flat config * Switch from UglifyJS to SWC, enforce ES 5 * Add `.editorconfig` & `.gitattributes` files * Update `.gitignore` to include more patterns from jQuery Core Closes gh-247
|
Landed on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
.editorconfig&.gitattributesfiles.gitignoreto include more patterns from jQuery CoreI'm considering further changes for the future, like:
We could then release such a smaller version as 4.0.0. I just wanted to add some real CI on real browsers first.
I know we discussed potentially deprecating this plugin and just telling people to use the
wheelevent directly. The problem is thewheelevent may report deltas in pixels, lines or pages. Chrome may report pixels or pages, Firefox can report all three depending on input devices. This plugin can be useful to get some pixel-based normalization; as long as browsers don't provide that out of the box, I see some value in this plugin. There are some discussions about always exposing pixels, perhaps in addition to other modes, in w3c/uievents#181, but so far the discussion has stalled.That said, I had a look at jQuery UI and it only cares about the wheel direction and only in one place so I don't see why UI needs to depend on this plugin anymore.