Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jQuery bug #10420. Get mousewheel values from original event. #15

Closed
wants to merge 2 commits into from

Conversation

dmethvin
Copy link
Member

jQuery 1.7 did a spring cleaning on event properties and made them event-specific as well, so these values are no longer copied to the fixed jQuery event.

Oh, and hey @brandonaaron!!

jQuery 1.7 did a spring cleaning on event properties and made them event-specific as well, so these values are no longer copied to the fixed jQuery event.
@thomasbilk
Copy link

This does not seem to suffice. I get another error a few lines below because event does not have a handle attribute.
With $.event.dispatch.apply(this, args) the plugin works again.

@dmethvin
Copy link
Member Author

Please use http://code.jquery.com/jquery-git.js for testing, it is what will become 1.7.

@brandonaaron
Copy link
Contributor

Thanks for the heads up! I've updated the plugin to be compatible with jQuery 1.7. The one thing I did have to add was the usage of the mouseHooks to get properties like pageX/Y.

@heylinus
Copy link

heylinus commented Nov 4, 2011

Not working in Firefox on MacOSX
console.log(delta, deltaX, deltaY);
outputed:
0 0 0

jquery 1.7
jquery-mousewheel git
firefox 7.0.1
mac os x 10.6.6

webkit(chrome, safari) is fine.

@Kienz
Copy link

Kienz commented Nov 4, 2011

The same problem in Firefox 7 & Opera 11.50 on Windows XP.

@ghost
Copy link

ghost commented Nov 9, 2011

In firefox (all OS and all versions) with jQuery 1.7 allways return delta 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants