Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: upgrade dependencies, including [email protected] #563

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Build: upgrade dependencies, including [email protected] #563

merged 2 commits into from
Feb 18, 2025

Conversation

timmywil
Copy link
Member

  • does not update sinon, uglify-js, or eslint

@timmywil
Build: upgrade dependencies, including [email protected]
0809ef2 
- does not update sinon, uglify-js, or eslint
@timmywil timmywil requested a review from mgol February 18, 2025 15:41
mgol
mgol approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@mgol mgol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but updating UglifyJS - and Sinon, though not to the latest version - should be fine on main, shouldn't it?

@timmywil
Copy link
Member Author

Good point. Updated as much as I could.

@timmywil timmywil requested a review from mgol February 18, 2025 18:00
@timmywil timmywil merged commit 272fb66 into jquery:main Feb 18, 2025
9 checks passed
@timmywil timmywil deleted the jtr_upgrade branch February 18, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgol mgol mgol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timmywil @mgol