Build: Test more browsers and jquery versions in pull requests #551
Conversation
253de08 to
d74b346
Compare
|
Of course, this will fail now since |
There was a problem hiding this comment.
Technically, we could run most tests on Safari or Windows instead of Ubuntu and shorten the config by 1/3.
Now that I think about it, we considered that before and it turned out Ubuntu was too fast to drop.
Please make your commit message more specific. For instance,
Build: Test more browsers and jquery versions in pull requests
I was following what we have set up in Core. I think Ubuntu actions run faster in CI than Windows - see this UI one for an example - so it's best to use them when Windows or macOS is not needed. |
|
Indeed, I edited my comment. Ubuntu is worth keeping. |
b5f6958 to
e6413ca
Compare
|
@timmywil updated, PTAL |
e6413ca to
76f8055
Compare
.github/workflows/browser-tests.yml
Outdated
| --jquery 3.7.1 --jquery 3.7.1.slim \ | ||
| --jquery 3.6.4 --jquery 3.5.1 --jquery 3.4.1 \ | ||
| --jquery 3.3.1 --jquery 3.2.1 --jquery 3.1.1 --jquery 3.0.0 \ | ||
| --retries 3 --hard-retries 1 |
There was a problem hiding this comment.
@timmywil I wonder if that's not too much for PRs and browsers running directly on the machines. What would you recommend?
There was a problem hiding this comment.
@mgol Agreed. That's a lot of retries for PRs. How about just one retry and no hard retries. We can leave those to browserstack.
76f8055 to
c4f42e9
Compare
Improve the actions setup for PRs so that more issues are detected pre-merge. Changes: 1. Test on Edge in IE mode 2. Test on more jQuery versions: `git`, `3.x-git`, `3.7.1` & their slim versions as well as full versions of each `3.x` jQuery minor. This is still fewer tests than post-merge: we don't test all slim versions and Migrate dev, but this should cover the majority of cases.
c4f42e9 to
3371fa7
Compare
Improve the actions setup for PRs so that more issues are detected pre-merge.
Changes:
git,3.x-git,3.7.1& their slim versions as well as full versions of each3.xjQuery minor.This is still fewer tests than post-merge: we don't test all slim versions and Migrate dev, but this should cover the majority of cases.
This was triggered by me breaking
maindespite all my PRs being green when merging. Migrate often treats older Core versions differently so testing on at least all full minors is pretty important...