Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Update dependencies, keep legacy jQueries in the repository #134

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

mgol
Copy link
Member

@mgol mgol commented Oct 11, 2022

Apart from updating npm dependencies, we now keep legacy jQuery versions - ones that were not published to npm - directly in the external-legacy-source folder instead of installing GitHub repositories as npm packages.

This will resolve some vulnerability reports about dev dependencies.

@mgol mgol added this to the 3.0.0 milestone Oct 11, 2022
@mgol mgol force-pushed the update-deps branch 4 times, most recently from 1a42d10 to ded9161 Compare October 11, 2022 13:27
@mgol mgol closed this Oct 11, 2022
@mgol mgol reopened this Oct 11, 2022
Apart from updating npm dependencies, we now keep legacy jQuery versions -
ones that were not published to npm - directly in the `external-legacy-source`
folder instead of installing GitHub repositories as npm packages.

The `external` directory is no longer kept in the repository; it's generated
on the fly instead.
@mgol mgol requested a review from fnagel October 11, 2022 14:19
Copy link
Member

@fnagel fnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by reading

@mgol mgol merged commit e865fdf into jquery:main Oct 11, 2022
@mgol mgol deleted the update-deps branch October 11, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants