Skip to content

Build updates #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 2, 2017
Merged

Build updates #114

merged 6 commits into from
Apr 2, 2017

Conversation

mgol
Copy link
Member

@mgol mgol commented Apr 1, 2017

This all makes sense to land as separate commits but I didn't want to report 5 tiny PRs.

@mgol mgol mentioned this pull request Apr 1, 2017
Safari changed its versioning scheme; it now releases every version for last
three macOS versions; previously it used weird versioning where releases for
previous macOS versions kept the original major number and only updated the
minor; that's no longer the case.
@raphamorim
Copy link
Member

👍

@raphamorim raphamorim merged commit 485460c into jquery:master Apr 2, 2017
@mgol
Copy link
Member Author

mgol commented Apr 2, 2017

Hmm, I wanted to land it as separate commits, i.e. "rebase & merge", not "squash & merge". :) But that's not terribly important.

Note that if you use the GitHub "squash & merge" or "rebase & merge" you should remove the PR reference from the commit message and move it to the commit description; in this case (#114) should disappear from the message and a new line saying Closes #114 should be added; see https://contribute.jquery.org/commits-and-pull-requests/#commit-guidelines for more details.

@mgol mgol deleted the build-updates branch April 2, 2017 16:59
@raphamorim
Copy link
Member

Oh, I didn't know about that 😭
Sorry @mgol.

@mgol mgol added this to the 3.0.0 milestone May 6, 2020
@mgol mgol added the build label May 6, 2020
@mgol mgol modified the milestones: 3.0.0, 2.2.0 May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants