Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Restore Node 18 support #633

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Build: Restore Node 18 support #633

merged 1 commit into from
Mar 10, 2025

Conversation

mgol
Copy link
Member

@mgol mgol commented Mar 10, 2025

jqueryui.com uses Node 18 for now and it uses this package.

@mgol mgol self-assigned this Mar 10, 2025
jqueryui.com uses Node 18 for now and it uses this package.
Comment on lines +14 to +15
# Node.js 18 is required by jqueryui.com
# Remember to include the version used in Dockerfile!
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misunderstood the previous comment to mean the Dockerfile but it was actually also about jqueryui.com, so I fixed it.

@mgol
Copy link
Member Author

mgol commented Mar 10, 2025

This is pretty obvious, so I'm just going to merge it.

@mgol mgol removed the Needs review label Mar 10, 2025
@mgol mgol merged commit a8e1837 into jquery:main Mar 10, 2025
4 checks passed
@mgol mgol deleted the node-18 branch March 10, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant