Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All: Drop the modern-syslog dependency, always use console directly #631

Merged
merged 1 commit into from
Mar 8, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -55,7 +55,6 @@ One version with the `stable` property set to `true` is required. Each release h
### node server.js

Use `node server.js` to run the server. Arguments:
- `--console` output to console instead of syslog (via simple-log module);
- `--host=<name>` specify custom host. Default localhost;
- `--nocache` skip caching release files and theme images;
- `--port=<number>` specify custom port. Default 8088;
3 changes: 1 addition & 2 deletions download.js
Original file line number Diff line number Diff line change
@@ -5,7 +5,6 @@ var cache, downloadLogger, jqueryUis,
fs = require( "node:fs" ),
Handlebars = require( "handlebars" ),
JqueryUi = require( "./lib/jquery-ui" ),
logger = require( "./lib/simple-log" ).init( "download.jqueryui.com" ),
Packager = require( "node-packager" ),
querystring = require( "querystring" ),
themeGallery = require( "./lib/themeroller-themegallery" )(),
@@ -76,7 +75,7 @@ Frontend.prototype = {
jqueryUi = JqueryUi.find( params.version );
}
if ( jqueryUi == null ) {
logger.error( "Invalid input \"version\" = \"" + params.version + "\"" );
console.error( "Invalid input \"version\" = \"" + params.version + "\"" );
data = { error: "invalid version" };
} else {
data = { categories: jqueryUi.categories };
5 changes: 2 additions & 3 deletions lib/cache.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
"use strict";

var Cache, cacheCron, cacheCronTimeout, cacheExpiresTime, caches,
logger = require( "./simple-log" ).init( "download.jqueryui.com" );
var Cache, cacheCron, cacheCronTimeout, cacheExpiresTime, caches;

cacheExpiresTime = 0;
caches = [];
@@ -22,7 +21,7 @@ cacheCron = function() {
}
} );

logger.log( cache.name + " Cleanup:", count );
console.log( cache.name + " Cleanup:", count );
} );
cacheCronTimeout = setTimeout( cacheCron, cacheExpiresTime );
};
47 changes: 0 additions & 47 deletions lib/simple-log.js

This file was deleted.

3 changes: 1 addition & 2 deletions lib/themeroller.js
Original file line number Diff line number Diff line change
@@ -3,7 +3,6 @@
var colorVars, textureVars, themeStaticCss,
async = require( "async" ),
Image = require( "./themeroller-image" ),
logger = require( "./simple-log" ).init( "download.jqueryui.com" ),
querystring = require( "querystring" ),
JqueryUi = require( "./jquery-ui" ),
semver = require( "semver" ),
@@ -351,7 +350,7 @@ ThemeRoller.prototype = {
var imageFiles = {};
if ( err ) {
err.message = "ThemeRoller#generateImages: " + err.message;
logger.error( err.message );
console.error( err.message );
callback( err );
} else {
results.forEach( function( file ) {
24 changes: 0 additions & 24 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -34,9 +34,6 @@
"winston": "^3.17.0",
"wolfy87-eventemitter": "5.2.9"
},
"optionalDependencies": {
"modern-syslog": "1.2.0"
},
"main": "main.js",
"scripts": {
"test": "qunit --require ./test/setup.js test"
6 changes: 2 additions & 4 deletions server.js
Original file line number Diff line number Diff line change
@@ -2,10 +2,8 @@

"use strict";

var logger = require( "./lib/simple-log" ).init( "download.jqueryui.com" );

process.on( "uncaughtException", function( err ) {
logger.error( "Caught exception: " + ( err.stack || err ) );
console.error( "Caught exception: " + ( err.stack || err ) );
process.exit( 1 );
} );

@@ -69,7 +67,7 @@ if ( !argv.nocache ) {
// OBS: We were using an older version of connect, which lacked a descent way to centralize
// requests error handling. We use express now but we haven't updated that code.
function error( err, response ) {
logger.error( "User request exception: " + ( err.stack || err ) );
console.error( "User request exception: " + ( err.stack || err ) );
frontend.error( response );
}