Template: Add support for jQuery UI 1.14 #616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmywil
reviewed
Jun 10, 2024
| " factory( jQuery );\n" + | ||
| " }\n" + | ||
| "} )( function( $ ) {\n" + | ||
| "\"use strict\";\n"; |
There was a problem hiding this comment.
These are long enough, it might be nice to use external wrapper.js files instead.
There was a problem hiding this comment.
Yeah. Even better if they were defined in the jQuery UI repo, not here, but I guess that ship has sailed...
There was a problem hiding this comment.
But they were already defined inline, just in two files instead of one. I'd consider this to be an improvement to be addressed separately, not blocking this PR.
Differences between them were already minimal; the few differences are now accounted for directly in the `package.js` code. Ref jquerygh-616
Also, rename `jquery-ui-1-12.js` to `jquery-ui-manifests.js` to account for it now being used for all jQuery UI versions. Ref jquerygh-616
`download.jqueryui.com` has been using two very similar versions of themeroller: one in the repository and another one from the `jquery-ui-themeroller` package. This change makes it only use the in-repo one, with the intent to eventually deprecate the outside repository & the associated npm package. Ref jquerygh-616
|
Landed in 70713ec...6aa903a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge a couple of files to avoid creating new files for 1.14. Add support where needed. Drop
jquery-ui-themerollerwhich duplicated lots of code from this package and made maintenance harder.When this lands, I'll still need to add the 1.14 beta to the download matrix but I'll do that separately.